search

amenezes / config-client

config-client package for spring cloud config and cloud foundry
https://config-client.amenezes.net/
Apache License 2.0
24 stars 18 forks source link

Fix dev environment setup #49

Closed LiorHalfon closed 1 year ago

LiorHalfon commented 1 year ago

Hey,

This PR fixes 2 issues when setting up the dev environment:

  1. After running make install-deps I got: 
    pre-commit install
make: pre-commit: No such file or directory

    According to pre-commit doc, pre-commit should be added to requirements-dev.txt Adding pre-commit to requirements-dev.txt fixed this issue.

  1. After running make tests I got this error: 
    File "/Users/lior.h/git/config-client/venv/lib/python3.11/site-packages/coverage/files.py", line 344, in _glob_to_regex
raise ConfigError(f"File pattern can't include {m[0]!r}")
coverage.exceptions.ConfigError: File pattern can't include '**/**'
make: *** [tests] Error 1

    According to this SO answer seems that in this version of coverage.py, there was a change to pattern matching that caused the above error. I fixed the patterns and tested that the coverage works as expected.

amenezes commented 1 year ago

@LiorHalfon,

Thank you very much for the fixes and really sorry for the long delay.