search

ament / ament_index

Apache License 2.0
13 stars 27 forks source link

avoid multiple calling compinit even if it could be in the first call. #87

Open iuhilnehc-ynos opened 2 years ago

iuhilnehc-ynos commented 2 years ago

Signed-off-by: Chen Lihui lihui.chen@sony.com

iuhilnehc-ynos commented 2 years ago

to fix https://github.com/ros2/ros2_documentation/issues/2944

iuhilnehc-ynos commented 2 years ago

close it as it has a potential issue if there defines a function named complete.

iuhilnehc-ynos commented 2 years ago

close it as it has a potential issue if there defines a function named complete.

This behavior is unexpected even if using the bash, so I'll continue to push this PR.

mjbogusz commented 2 years ago

Cross-ref https://github.com/ros2/ros2cli/issues/534

close it as it has a potential issue if there defines a function named complete.

This behavior is unexpected even if using the bash, so I'll continue to push this PR.

See https://github.com/ros2/ros2cli/pull/750 for an approach that doesn't collide with a complete function... But I'm not sure whether it's 100% correct either.