search

ament / ament_index

Apache License 2.0
13 stars 27 forks source link

only append search paths on first PackageNotFound #91

Closed lucasw closed 8 months ago

lucasw commented 11 months ago

I played a ros bag and got more than ten package not found warnings which took up a lot of lines of terminal output:

Ignoring a topic '/fmu/out/vehicle_status', reason: package 'px4_msgs' not found, searching: [/home/lucasw/ros/ros2_rolling/install/rqt_bag_plugins, /home/lucasw/ros/ros2_rolling/install/rosbag2, /home/lucasw/ros/ros2_rolling/install/rosbag2_storage_default_plugins, ...

Only the first instance was useful if I were to inspect the path output (though even printing out one complete set takes many lines of wrapped output), so limiting that here, it prints the first one fully then is more concise:

...
/home/lucasw/ros/ros2_rolling/install/ament_flake8, /home/lucasw/ros/ros2_rolling/install/ament_copyright, /home/lucasw/ros/ros2_rolling/install/ament_lint, /home/lucasw/ros/ros2_rolling/install/ament_index_python, /home/lucasw/ros/ros2_rolling/install/ament_index_cpp, /home/lucasw/ros/ros2_rolling/install/ament_cpplint, /home/lucasw/ros/ros2_rolling/install/ament_cppcheck, /home/lucasw/ros/ros2_rolling/install/ament_clang_tidy, /home/lucasw/ros/ros2_rolling/install/ament_clang_format].
[WARN] [1702825347.983349419] [rosbag2_player]: Ignoring a topic '/fmu/out/vehicle_odometry', reason: package 'px4_msgs' not found.
[WARN] [1702825347.983974247] [rosbag2_player]: Ignoring a topic '/fmu/out/vehicle_local_position', reason: package 'px4_msgs' not found.
[WARN] [1702825347.984591679] [rosbag2_player]: Ignoring a topic '/fmu/out/failsafe_flags', reason: package 'px4_msgs' not found.
[WARN] [1702825347.985206149] [rosbag2_player]: Ignoring a topic '/fmu/out/timesync_status', reason: package 'px4_msgs' not found.
[WARN] [1702825347.985826904] [rosbag2_player]: Ignoring a topic '/fmu/out/vehicle_control_mode', reason: package 'px4_msgs' not found.
quarkytale commented 8 months ago

Don't see any major problems with this one. ~But a thought, the printed lines are for separate packages missing px4_msgs, if we remove the other lines but keep only one folks might disregard it if that package isn't relevant for their usecase?~

Oh my bad this is just removing the appended paths!

quarkytale commented 8 months ago

CI:

quarkytale commented 8 months ago

Test failures are unrelated, getting this in!