ament / ament_lint

Apache License 2.0
38 stars 107 forks source link

Added undescore to ignore new pydocstyle item #428

Closed Crola1702 closed 1 year ago

Crola1702 commented 1 year ago

Signed-off-by: Crola1702 cristobal.arroyo@ekumenlabs.com

Pydocstyle 6.2.0 introduced a new feature where get_files_to_check method yields 4 items instead of 3.

This PR adds and ignores that item, so the tests can run without crashing.

Crola1702 commented 1 year ago

Rolling CI is installing Pydocstyle 6.1.1:

00:01:00.043 pydocstyle: 6.1.1-1
Crola1702 commented 1 year ago

CI:

Linux CI is upgrading to 6.2.1

Collecting pydocstyle
  Downloading pydocstyle-6.2.1-py3-none-any.whl (37 kB)
Collecting pyflakes
  Downloading pyflakes-3.0.1-py2.py3-none-any.whl (62 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 62.8/62.8 KB 11.4 MB/s eta 0:00:00
...
pydocstyle==6.2.1
Crola1702 commented 1 year ago

CI:

clalancette commented 1 year ago

This is all green, so merging this in.

clalancette commented 1 year ago

@Mergifyio backport humble

mergify[bot] commented 1 year ago

backport humble

✅ Backports have been created

* [#429 Added undescore to ignore new pydocstyle item (backport #428)](https://github.com/ament/ament_lint/pull/429) has been created for branch `humble`
Crola1702 commented 1 year ago

@mergify backport foxy

mergify[bot] commented 1 year ago

backport foxy

❌ Command disallowed due to command restrictions in the Mergify configuration.

- [ ] `sender-permission>=write`
clalancette commented 1 year ago

@Mergifyio backport foxy

mergify[bot] commented 1 year ago

backport foxy

✅ Backports have been created

* [#431 Added undescore to ignore new pydocstyle item (backport #428)](https://github.com/ament/ament_lint/pull/431) has been created for branch `foxy`
ijnek commented 1 year ago

Could we get a release in foxy so we can get this change please? I believe everyone's foxy CIs for ros2 python packages are failing without this change right now. Thanks!

Crola1702 commented 1 year ago

Could we please get a release in foxy so we can get this change please?

FYI: @jacobperron

clalancette commented 1 year ago

I'll comment over on the backport PR.