search

ament / ament_lint

Apache License 2.0
38 stars 107 forks source link

Convert linenumber to string when printing errors #443

Closed rjb0026 closed 1 year ago

rjb0026 commented 1 year ago

Potential fix for #442.

clalancette commented 1 year ago

CI:

clalancette commented 1 year ago

The one failing test on Windows is a known flake, so going ahead and merging this one. Thanks for the improvement!

rjb0026 commented 1 year ago

@clalancette awesome! glad to see this one get through. I wasn't sure what the procedure is for getting this into humble and iron, but that's still something I'd like to see happen. Should I just open PRs targeting the humble and iron branches?

clalancette commented 1 year ago

@Mergifyio backport humble iron

mergify[bot] commented 1 year ago

backport humble iron

✅ Backports have been created

* [#446 Convert linenumber to string when printing errors (backport #443)](https://github.com/ament/ament_lint/pull/446) has been created for branch `humble` * [#447 Convert linenumber to string when printing errors (backport #443)](https://github.com/ament/ament_lint/pull/447) has been created for branch `iron`