search

ament / ament_lint

Apache License 2.0
37 stars 107 forks source link

`InsertNewlineAtEOF` entry seen as invalid argument #498

Open luym11 opened 3 months ago

luym11 commented 3 months ago

I added one entry to my .clang-format file, namely the InsertNewlineAtEOF: true line. Now the .clang-format looks like:

Language: Cpp BasedOnStyle: Google

AccessModifierOffset: -2 AlignAfterOpenBracket: AlwaysBreak BraceWrapping: AfterClass: true AfterFunction: true AfterNamespace: true AfterStruct: true BreakBeforeBraces: Custom ColumnLimit: 100 ConstructorInitializerIndentWidth: 0 ContinuationIndentWidth: 2 DerivePointerAlignment: false InsertNewlineAtEOF: true PointerAlignment: Middle ReflowComments: false ...

However, when running ament_clang_format --config ./clang-format I got:

{AccessModifierOffset: -2, AlignAfterOpenBracket: AlwaysBreak, BasedOnStyle: Google, BraceWrapping: {AfterClass: true, AfterFunction: true, AfterNamespace: true, AfterStruct: true}, BreakBeforeBraces: Custom, ColumnLimit: 100, ConstructorInitializerIndentWidth: 0, ContinuationIndentWidth: 2, DerivePointerAlignment: false, InsertNewlineAtEOF: true, Language: Cpp, PointerAlignment: Middle, ReflowComments: false}
                                                                                                                                                                                                                                                                                                                                    ^~~~~~~~~~~~~~~~~~
Error parsing -style: Invalid argument
<command-line>:1:325: error: unknown key 'InsertNewlineAtEOF'

several times. Removing this line fixes the issue.

MichaelOrlov commented 2 months ago

@wjwwood Could you please help to triage this issue?