search

ament / google_benchmark_vendor

Vendor package for providing Google Benchmark
Apache License 2.0
1 stars 7 forks source link

Update google_benchmark to v1.5.3 #16

Closed homalozoa closed 3 years ago

homalozoa commented 3 years ago
  1. Change google_benchmark version from v1.5.2 to v1.5.3. Because v1.5.2 can not build with GCC 11
  2. Removed shrink-tz-offset-size.patch because of this patch was merged in google-benchmark repo.

Signed-off-by: Homalozoa nx.tardis@gmail.com

clalancette commented 3 years ago

Let's run CI with this and see how it looks:

clalancette commented 3 years ago

I think that the CMake warnings on aarch64 and Windows are expected for the performance benchmarks, but I'm not sure. @cottsay Could you take a look at this PR and the CI run and see if it makes sense to you?

cottsay commented 3 years ago

Could you take a look at this PR and the CI run and see if it makes sense to you?

Yes, those warnings are expected with AMENT_RUN_PERFORMANCE_TESTS. This change looks good to me.

clalancette commented 3 years ago

Yes, those warnings are expected with AMENT_RUN_PERFORMANCE_TESTS. This change looks good to me.

Thanks, appreciated. Then I'll go ahead and merge this.