search

ament / googletest

Google Test
BSD 3-Clause "New" or "Revised" License
3 stars 9 forks source link

Upgrade cmake minimum versions to 2.8.12 #11

Closed brawner closed 3 years ago

brawner commented 3 years ago

In the most recent release of cmake (3.19), they have started deprecating cmake versions < 2.8.12. While a similar change has been proposed, it has not yet been added to the upstream repo (https://github.com/google/googletest/pull/3094).

https://ci.ros2.org/view/nightly/job/nightly_win_rel/1760/cmake/

Build all of ros2, testing up to rcutils

Signed-off-by: Stephen Brawner brawner@gmail.com

sloretz commented 3 years ago

CI https://github.com/ros/urdfdom_headers/pull/67#issuecomment-733042583

brawner commented 3 years ago

CI results:

Based on these results, it looks like cmake warnings due to googletest in the ament directory have been resolved. I think the googletest failures in the above windows job are all coming from osrf_testing_tools_cpp (https://github.com/osrf/osrf_testing_tools_cpp/pull/61)

brawner commented 3 years ago

Testing again with only this branch, --packages-up-to rcutils

brawner commented 3 years ago

Only one cmake warning, which is due to mimick and a PR is already open. https://github.com/ros2/Mimick/pull/15

brawner commented 3 years ago

Ok, trying just patching .install files.

brawner commented 3 years ago

@clalancette It looks like reducing the scope of the patch worked. The only cmake warning on windows was due to mimick, which has now been addressed in https://github.com/ros2/mimick_vendor/pull/14