search

ament / googletest

Google Test
BSD 3-Clause "New" or "Revised" License
3 stars 9 forks source link

Fix warning maybe-uninitialized (backport #16) #18

Closed mergify[bot] closed 3 years ago

mergify[bot] commented 3 years ago

This is an automatic backport of pull request #16 done by Mergify.

Mergify commands and options
More conditions and actions can be found in the [documentation](https://docs.mergify.io/). You can also trigger Mergify actions by commenting on this pull request: - `@Mergifyio refresh` will re-evaluate the rules - `@Mergifyio rebase` will rebase this PR on its base branch - `@Mergifyio update` will merge the base branch into this PR - `@Mergifyio backport ` will backport this PR on `` branch Additionally, on Mergify [dashboard](https://dashboard.mergify.io/) you can: - look at your merge queues - generate the Mergify configuration with the config editor. Finally, you can contact us on https://mergify.io/
clalancette commented 3 years ago

CI:

clalancette commented 3 years ago

There's a mypy failure on all platforms; that is almost certainly not because of this.

macOS has one additional failure in laser_project_test, but that also seems unrelated.

Windows has 10 failures, one of which is the mypy failure. I don't know if the other 9 are expected on Foxy; @jacobperron what do you think?

jacobperron commented 3 years ago

The mypy failures have been around for a while now; same for the laser_geometry failure.

Windows CI has been slowly degrading, but those failures look pre-existing to me.