Unconditionally add -pthread to googletest for Linux.

ament / googletest

Google Test

BSD 3-Clause "New" or "Revised" License

3 stars 9 forks source link

Closed clalancette closed 5 years ago

clalancette commented 5 years ago

This ensures that we always link against pthread, even when asan is in use.

Along with similar fixes in Fast-RTPS and osrf/osrf_testing_tools_cpp#21, this allows ros2 to build with the colcon asan mixin (as discussed in https://github.com/colcon/colcon-mixin-repository/pull/12)

clalancette commented 5 years ago

Here's a CI run to show that we haven't broken anything (but that does not use the asan mixin):

clalancette commented 5 years ago

Another CI to make sure things are happy:

clalancette commented 5 years ago

The warnings on the Windows build are because of something else (it seems like specific to the icecube build machine, i.e. https://ci.ros2.org/view/nightly/job/nightly_win_deb/1112). With a clean CI and an approval, merging.