search

ament / googletest

Google Test
BSD 3-Clause "New" or "Revised" License
3 stars 9 forks source link

update for GTEST_SKIP feature #5

Closed wjwwood closed 5 years ago

wjwwood commented 5 years ago

Continuation of https://github.com/ament/googletest/pull/4

I setup this branch as what I'd reset ros2 to be:

https://github.com/ament/googletest/tree/update_for_skip_feature

I'd also fast-forward our master to c6cb7e0, on which the above branch is based. I also cherry-picked our four commits onto that commit.

If I get a 👍 from @pbaughman, and CI is green I'll reset ros2 to be this branch and fast-forward master.

wjwwood commented 5 years ago

CI:

pbaughman commented 5 years ago

@wjwwood Looks good - this matches what I have internally

pbaughman commented 5 years ago

The test failures all look like pytests. I don't know what's going on there

wjwwood commented 5 years ago

Those are known flaky.

wjwwood commented 5 years ago

Ok, it's done. I also sent a notice for people with source checkouts:

https://discourse.ros.org/t/notice-force-push-on-ament-googletest/8616