search

amenzhinsky / dbus-codegen-go

D-Bus code-generation for golang
MIT License
16 stars 14 forks source link

Update "do not edit" comment to be recognzed by golint etc. #1

Closed schiffermtq closed 4 years ago

schiffermtq commented 5 years ago

As described in [1], and implemented for protoc-gen-go in [2], the "do not edit" comment must have a specific format to be recognized by tools, for example to exclude a file from linting.

Without this change, golint will warn about underscores in method names.

[1] https://github.com/golang/go/issues/13560#issuecomment-288457920 [2] https://github.com/golang/protobuf/commit/47eb67eaf5cab63c58956d4d4ce86b03ad5eaa03

menzels commented 4 years ago

i would like to have this feature. a merge would be awesome :-)

amenzhinsky commented 4 years ago

Sorry haven't seen this before, @menzels @schiffermtq seems like I added this separately, should be in master.

schiffermtq commented 4 years ago

Indeed, a similar change is already in master.