search

amenzhinsky / iothub

Azure IoT Hub SDK for Golang
MIT License
51 stars 57 forks source link

Unneeded timeout #12

Closed maxtar closed 4 years ago

maxtar commented 5 years ago

Hi.

In our project I've faced with 30s timeout when twin updates. But in transport setting and context I set 2 minutes. I've found the following code. Is it really need this constant timeout?

amenzhinsky commented 4 years ago

Hi @maxtar, that makes sense to remove the timeout because we're passing ctx along with every request. Would you like to create a MR?

maxtar commented 4 years ago

@amenzhinsky Do you mean PR? Or what is MR?

amenzhinsky commented 4 years ago

@maxtar sure PR, I'm mixing up github and gitlab terminology a bit.

maxtar commented 4 years ago

@amenzhinsky :) Ok, will create PR. :)

amenzhinsky commented 4 years ago

Closed via https://github.com/amenzhinsky/iothub/commit/bd88648ef55cea635ca3ae095a649c74299ff8a1

maxtar commented 4 years ago

Ups, sorry. :( Was vacation.