search

amenzhinsky / iothub

Azure IoT Hub SDK for Golang
MIT License
51 stars 57 forks source link

MQTT over Websocket in ModuleTransport Connect method #39

Closed zsombix closed 3 years ago

zsombix commented 3 years ago

Hello,

I've noticed that the ModuleTransport does not allow for MQTT over websocket like Transport implementation in the mqtt package:

https://github.com/amenzhinsky/iothub/blob/0dae904c631b9bb6f71b3327125a08352622c560/iotdevice/transport/mqtt/module_mqtt.go#L64

https://github.com/amenzhinsky/iothub/blob/0dae904c631b9bb6f71b3327125a08352622c560/iotdevice/transport/mqtt/mqtt.go#L130

Was that intentional? If there was no reason, like it's not supported, I would add it to ModuleTransport.

amenzhinsky commented 3 years ago

Hi @zsombix as far as I remember the module transport was a simple copy-paste-replace of the base transport, probably WS support was added later but wasn't implemented for modules.

Would you issue a PR?

zsombix commented 3 years ago

Yes I would add it with a PR. Probably not today 😃 .