search

amercier / ng-media-events

Angular directives for HTML5 audio/video media events
MIT License
4 stars 0 forks source link

What about fullscreen? #3

Closed bernardoadc closed 6 years ago

bernardoadc commented 6 years ago

Will it be supported? I realize that is tricky still today, but even more desirable to be in a lib. (not sure but I think videogular supports this).

amercier commented 6 years ago

Hi, what do you mean by "supporting fullscreen"? This project is about Media events.

You may want to combine this with some fullscreen-specific Angular directive.

bernardoadc commented 6 years ago

Oh, ok.. I thought it would support every event that involved a video tag, for example. To avoid things like this: https://developer.mozilla.org/en-US/docs/Web/API/Fullscreen_API#Prefixing. But now I see that altough we can call Element.requestFullscreen() the onfullscreenchange event will be bound to the whole document.

So in the end is a matter of web standard definition. Thanks

amercier commented 6 years ago

Yes, I try to keep this package minimal, so it only focuses on media events and stay as lightweight as possible. There might be some good modules for doing fullscreen out there, such as hrajchert/angular-screenfull or fabiobiondi/angular-fullscreen, but I haven't tested them.

(sorry for the possibly rude tone on my first message, it wasn't intentional)

bernardoadc commented 6 years ago

Nice, thanks for the tips! No worries, didn't sound rude to me at all Keep up the good work!