search

american-art / AAT-Term-Mappings

This repository contains .XLS files of partner mapped Classification and Role terms. Partners extracted distinct object Classification terms and constituent Role terms and found AAT term equivalents.
GNU General Public License v3.0
4 stars 1 forks source link

Gilcrease Classifications file is outdated #3

Open VladimirAlexiev opened 7 years ago

VladimirAlexiev commented 7 years ago

Gilcrease AAC Classification Mapping (8.2.16).xlsx maps "Anth- Ceramic, Plaster" to "materials by composition". This is definitely wrong:

I can't find on google what is this special plaster. But explore the plaster hirerarchy and pick something.

kateblanch commented 7 years ago

@diana-folsom

Diana-Folsom commented 7 years ago

It sounds like the old, incorrect version of the data is being used. These old, whacky categories should have been deleted in the newer version of data.

caknoblock commented 7 years ago

You can review the version of the data that we are using here: https://github.com/american-art/AAT-Term-Mappings/tree/master/karma/cleaned_data https://github.com/american-art/AAT-Term-Mappings/tree/master/karma/cleaned_data and this file can be updated, but it needs to be in this format.

On Mar 4, 2017, at 4:22 PM, Diana-Folsom notifications@github.com wrote:

It sounds like the old, incorrect version of the data is being used. These old, whacky categories should have been deleted in the newer version of data.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/american-art/AAT-Term-Mappings/issues/3#issuecomment-284195148, or mute the thread https://github.com/notifications/unsubscribe-auth/ABB-qUvPMFQ9_lPfDNBo4_jIY6WoPQvEks5rigA_gaJpZM4MLKkL.

{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/american-art/AAT-Term-Mappings","title":"american-art/AAT-Term-Mappings","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/american-art/AAT-Term-Mappings"}},"updates":{"snippets":[{"icon":"PERSON","message":"@Diana-Folsom in #3: It sounds like the old, incorrect version of the data is being used. These old, whacky categories should have been deleted in the newer version of data. "}],"action":{"name":"View Issue","url":"https://github.com/american-art/AAT-Term-Mappings/issues/3#issuecomment-284195! 148"}}}

Diana-Folsom commented 7 years ago

Craig, This is the old file - we updated our data and posted a new file in August, 2016.

Kate, Is there a different place or way in which we should post the data? I believe we used the same format as the original posting.

Although we not need to make some other Classification changes, I hope that the August data contribution can be the one used now, and we will contribute the changes we are making based on Vladimir's helpful observations.

Thanks! Diana

kateblanch commented 7 years ago

Hi @Diana-Folsom! Thanks for your help investigating. I see the file you posted in August - Gilcrease AAC Classification Mapping (8.2.16).xlsx. Is there a newer one that you posted after August 2nd?

I'm comparing the data Craig's using - https://github.com/american-art/AAT-Term-Mappings/tree/master/karma/cleaned_data/GM Classification.xlsx and this file Gilcrease AAC Classification Mapping (8.2.16).xlsx and they look the same.

Did the classifications get cleaned up at the object level, perhaps? This file https://github.com/american-art/GM/blob/master/Classifications/Classifications.csv seems to much fewer classifications.