american-art / PUAM

Princeton University Art Museum
Other
4 stars 4 forks source link

PUAM zombie constituents #47

Closed VladimirAlexiev closed 7 years ago

VladimirAlexiev commented 7 years ago

(Split from https://github.com/american-art/SAAM/issues/18. Related to #42, #46). apicongeography.json:

"ConGeographyID":1741,
"ConstituentID":6388,
"ConGeoCode":"Birth Place",
"Continent":"Europe",
"Country":"Belarus",
"City":"Viciebsk",

"ConGeographyID":1742,
"ConstituentID":6388,
"ConGeoCode":"Death Place",
"Continent":"Europe",
"Country":"France",
"City":"Saint-Paul-de-Vence",

But there is no record with Constituent ID 6388 in the apiconstituents file. So this says "there is a person who was born in Viciebsk and died in Saint-Paul-de-Vence, but we're not going to tell you his name". @kateblanch Can you please ask the PUAM person to take care of this. I could try to cross-ref the two JSON files...

@bsnikhila said: this is why it is appearing as a zombie: http://data.americanartcollaborative.org/puam/constituent/6388. But by the same logic, how can you explain how http://data.americanartcollaborative.org/puam/constituent/6351 has only type, but no http://data.americanartcollaborative.org/puam/constituent/6351/birth and death nodes?

kateblanch commented 7 years ago

@cathryng - checking in to see if there's a way to double check the contents of your constituents file vs. the objects file? there may be instances where you have constituents listed that are not included in the objects file.

VladimirAlexiev commented 7 years ago

CCMA has a similar problem and I extracted some IDs for them: https://github.com/american-art/ccma/issues/25

cathryng commented 7 years ago

ah, it is true that i didn't filter all of the sub-data files from constituents for "American" can we just drop the ones that don't link or do you want me to submit new data sets? this should also be the case with apiconuri.json i imagine.

caknoblock commented 7 years ago

Since we map each data file separately and then link them when they get loaded into the triple store, we don’t have a way to just drop the ones that don’t link. If David thinks these are a problem, then it would be great if you could submit new datasets with the format of the datasets unchanged.

On Apr 13, 2017, at 1:52 PM, cathryng notifications@github.com wrote:

ah, it is true that i didn't filter all of the sub-data files from constituents for "American" can we just drop the ones that don't link or do you want me to submit new data sets? this should also be the case with apiconuri.json i imagine.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/american-art/PUAM/issues/47#issuecomment-294018373, or mute the thread https://github.com/notifications/unsubscribe-auth/ABB-qTEkeBrP9_HkD-fL-6QHo-WKA0_2ks5rvor-gaJpZM4Mwvb2.

{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/american-art/PUAM","title":"american-art/PUAM","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/american-art/PUAM"}},"updates":{"snippets":[{"icon":"PERSON","message":"@cathryng in #47: ah, it is true that i didn't filter all of the sub-data files from constituents for \"American\" can we just drop the ones that don't link or do you want me to submit new data sets? this should also be the case with apiconuri.json i imagine."}],"action":{"name":"View Issue","url":"https://github.com/american-art/PUAM/issues/47#issuecomment-294018373"}}}

workergnome commented 7 years ago

Well, they're going to show up if they're published, so if we don't want them out there, they're going to need to be filtered out at some stage.

cathryng commented 7 years ago

yes - will have this to you tomorrow

bsnikhila commented 7 years ago

This seems to be fixed.