search

american-art / cbm

Crystal Bridges Museum
Creative Commons Zero v1.0 Universal
0 stars 2 forks source link

Production BOTB and EOTE are not typed. #45

Closed workergnome closed 7 years ago

workergnome commented 7 years ago

If I look at, say, http://data.americanartcollaborative.org/page/cbm/object/688/production/date

the dates are literals, but they're untyped.

I'd strongly recommend that any dates that go into the crm:P82a/b et al be xsd:dateTimes, not strings. That'll let us consistently do date math with them. It does mean that they'll have to be munged to actually meet that standard.

azaroth42 commented 7 years ago

At the very least they need to be the full dateTime format (yyyy-mm-ddThh:mm:ssZ) so they can cast correctly, even if the xsd:dateTime datatype is not explicitly asserted for the literal value.

bsnikhila commented 7 years ago

Changed to xsd:date.

workergnome commented 7 years ago

The label now no longer makes sense. It seems to state that this thing was made over the period of a year, rather that it was made at a point sometime within the year. I'd just leave the label as 1808.

bsnikhila commented 7 years ago

Is this only for productions. For actor birth and death dates, the label should be Start of the year to End of the year right?

workergnome commented 7 years ago

I don't think so—that wouldn't make sense. That would be a very long birth.

bsnikhila commented 7 years ago

Okay, so for both production and birth/death dates, I just leave the label as the year? The Begin of the Begin and End of the End will be typed as xsd:date.

workergnome commented 7 years ago

Correct. THE BOTB/EOTE should be precise xsd:dates, and the label should be the data as provided, so it's OK to be fuzzy there.