american-art / npg

National Portrait Gallery
Creative Commons Zero v1.0 Universal
1 stars 6 forks source link

NPGConstituents: Use of E39 Actor #38

Closed steads closed 7 years ago

steads commented 8 years ago

The mapping to E39 Actor is correct as there are both individuals (E21 Person) and groups (E74 Group). However this makes the mapping rather weak as the use of the superclass restricts the utility of the resulting data.

VladimirAlexiev commented 8 years ago

Right! I checked all values of column Institution, and indeed they represent Groups. With the possible exceptions of the following (most of them are not Persons either)

Ackerman Admiralty Arch Anonymous Loan to the Boston Athenaeum Antoinette Benjamin Harrison Presidential Site BELL, RON Belgrave Square Violinist Widow William You Can Please Some Of The... Young

VladimirAlexiev commented 8 years ago

As mentioned in #41, #42 this should be done. It's not hard to do: switch on presence of Institution field.

Steve, maybe change the title to "... use E21 Person vs E74 Group"

edgartdata commented 8 years ago

It seems that there is nothing for NPG to do here since they provided a separate Institution column with the names of the institutions and the value NULL for instances when the field does not apply to persons.