american-art / npg

National Portrait Gallery
Creative Commons Zero v1.0 Universal
1 stars 6 forks source link

(!) strange choice of URL for title #67

Closed VladimirAlexiev closed 6 years ago

VladimirAlexiev commented 7 years ago

http://data.americanartcollaborative.org/page/npg/thesauri/title/williammcchesneymartin

This is an extremely strange choice of URL. You don't put titles in thesauri, you put lookup lists (title type perhaps). Consider that a common word like "Flowers" could be a primary title of one painting but alternate title of another. You'd map them both to http://data.americanartcollaborative.org/page/npg/thesauri/title/flowers, thus mixing up the title types.

Instead of this, use the object ID and title ID, eg data.americanartcollaborative.org/npg/object/49748/title/23.

Note: using the title type is not good either (see https://github.com/american-art/cbm/issues/58 item 2), eg data.americanartcollaborative.org/npg/object/49748/title/alternate will mix up the values of two alternate titles.

VladimirAlexiev commented 7 years ago

CCMA has the same problem: http://data.americanartcollaborative.org/ccma/thesauri/title/stelizabethofhungary

VladimirAlexiev commented 7 years ago

GM has the same problem: http://data.americanartcollaborative.org/page/GM/thesauri/title/fromeaarisstonancycrussell

bsnikhila commented 6 years ago

Used the Object URI to make Title URIs where Title IDs are not provided.