Closed VladimirAlexiev closed 7 years ago
If the data's not there, then there's no data—I'm fine with that. Better than a blank timespan.
Check in the source data of PUAM, NPG whether they got no date & place of production
I'm trying very hard not to fall down the rabbit hole of reviewing mappings from the primary source material—it needs to be done, but I'm probably not the right person to be doing it.
@kateblanch Can the NPG person do this check? https://github.com/american-art/PUAM/issues/40 is the corresponding task for PUAM, and shows the query to get the offending object and production URLs.
@si-npg -- can you check your source data for production events with no dates (i.e. objects with no date created). You can click on this link to see a list of the Object IDs where this seems to be happening: http://yasgui.org/short/BkpGngn2e
Those objects have no date entered in our database. Begin Date and End Date cannot be null in TMS, so a 0 is automatically inserted for each. The display date field is either blank or has something like "n.d.a." entered.
@si-npg Which of the 602 objects did you check?
I checked the first few and then a few random ones. In our collections database, I called up all NPG objects with no dates and got 588 of them, most with nothing in the display field but some with "n.d.a." or "unknown", and a couple with "No date".
Thanks @si-npg! If you've exported all of your objects, close this. 602 is more than 588 but the number is close enough to spend effort chasing why. If you've exported only a selection, let's chase it.
I queried on objects with the same criteria as those I exported (accessioned objects that are checked for public access.) The small difference in the results represents the additional objects that now have that criteria. So I think we're good.
@workergnome This query finds Production events without any dates http://yasgui.org/short/B1gzArYne
Please check a few in different museums to see if you're ok with it. Checked a few NPG, they got only is_performed_by