search

american-art / npg

National Portrait Gallery
Creative Commons Zero v1.0 Universal
1 stars 6 forks source link

actor name part URLs #72

Closed VladimirAlexiev closed 7 years ago

VladimirAlexiev commented 7 years ago 
<npg/person-institution/31/primary_name> crm:P106_is_composed_of    
  <npg/person-institution/31/family_name_class>,
  <npg/person-institution/31/given_name_class>,
  <npg/person-institution/31middle_name_class>.

<npg/person-institution/31middle_name_class> a crm:E82_Actor_Appellation;
  crm:P2_has_type <npg/person-institution/31/middle_name_type_class>;
  rdf:value "Pitcher".

<npg/person-institution/31/middle_name_type_class> a crm:E55_Type;
  skos:broadMatch   <http://vocab.getty.edu/aat/300404654>.

URL Problems:

  1. family_name_class is misleading. That's his middle name, what does class mean here?
  2. 31middle_name_class is missing a slash. That's not consistent with the other name parts
  3. middle_name_type_class is wasteful because it makes a node per object. Use a shared node instead.

So change the above as follows (and same for family_name, given_name):

<npg/person-institution/31/primary_name> crm:P106_is_composed_of    
  <npg/person-institution/31/family_name>,
  <npg/person-institution/31/given_name>,
  <npg/person-institution/31/middle_name>.

<npg/person-institution/31/middle_name> a crm:E82_Actor_Appellation;
  crm:P2_has_type <npg/thesaurus/name/middle_name>;
  rdf:value "Pitcher".

<npg/thesaurus/name/middle_name> a crm:E55_Type;
  skos:broadMatch   <http://vocab.getty.edu/aat/300404654>.
bsnikhila commented 7 years ago

Changed them to '/given_name', '/middle_name' and '/family_name'.

The type nodes are 'thesauri/name_type/given_name', 'thesauri/name_type/middle_name' and 'thesauri/name_type/family_name'