americanexpress / eslint-config-amex

✨ This is American Express' eslint config
Apache License 2.0
40 stars 13 forks source link

feat(dependencies): add support for prettier 3 #126

Closed tejusunkara closed 7 months ago

tejusunkara commented 7 months ago

Description

Updates prettier peer dependency to support the current version 3

Motivation and Context

This allows users of this library to upgrade their prettier dependency without conflicting peer dependency. The current version of eslint-config-amex has a peer dep error when used with the current version of prettier.

› npm ls prettier
npm ERR! code ELSPROBLEMS
npm ERR! invalid: prettier@3.2.5 /[...]/ node_modules/prettier {module}@1.6.0 [...]/{module}
├─┬ eslint-config-amex@16.0.0
│ └─┬ prettier@3.2.5 deduped invalid: "^2.0.0" from node_modules/eslint-config-amex
└── prettier@3.2.5 invalid:"^2.0.0" from node_modules/eslint-config-amex

How Has This Been Tested?

Tested using npm pack, installed in a module using prettier 3.2.5 and peer dep errors were resolved:

› npm ls prettier
{module}@1.6.0 [...]/{module}
├─┬ eslint-config-amex@16.0.0
│ └─┬ prettier@3.2.5 deduped
└── prettier@3.2.5

Types of changes

CLAassistant commented 7 months ago

CLA assistant check
All committers have signed the CLA.

oneamexbot commented 7 months ago

:tada: This PR is included in version 16.1.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: