feat(ally): disallow nesting of controls in labels - Githubissues

americanexpress / eslint-config-amex

✨ This is American Express' eslint config

Apache License 2.0

40 stars 13 forks source link

feat(ally): disallow nesting of controls in labels #86

Closed code-forger closed 3 years ago

code-forger commented 3 years ago

Nesting controls inside of label has poor support in assistive technologies, instead enforce separate tags with an htmlFor on the label.

Please make sure that the PR fulfills these requirements

[x] I checked that there aren't other open Pull Requests for the same update/change.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation and I have updated the documentation accordingly.
[x] Rule changes includes a comment to describe the reasoning behind the change.
[x] PR contains a single rule change.

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation (adding or updating documentation)
[ ] Dependency update