americanexpress / eslint-config-amex

✨ This is American Express' eslint config
Apache License 2.0
40 stars 13 forks source link

chore(deps): replace `babel-eslint` with `@babel/eslint-parser` #94

Closed marcusrbrown closed 2 years ago

marcusrbrown commented 2 years ago

The babel-eslint package was deprecated at v10.1.0 and moved to @babel/eslint-parser.

Description

Replaced the deprecated babel-eslint dependency with @babel/eslint-parser. Added the requireConfigFile flag to the parserOptions key and disabled the requirement.

Please make sure that the PR fulfills these requirements

Motivation and Context

The babel-eslint package was deprecated at v10.1.0 and moved to the Babel monorepo as @babel/eslint-parser. This package must not depend on deprecated packages and should stay current with the Babel ecosystem.

How Has This Been Tested?

I ran npm ci, followed by npm test.

Types of changes

marcusrbrown commented 2 years ago

Looks like this will close #93.

marcusrbrown commented 2 years ago

Why such large changes to the lockfile?

I couldn't say specifically. There was a lot of refactoring done for Babel monorepo projects and replacing the older package would have brought in many current dependencies. Deps in eslint-config-amex are years out of date. I planned to leave npm audit on a separate PR. I'm blocked on work items until we can get this package up to date.

oneamexbot commented 2 years ago

:tada: This PR is included in version 15.0.3 :tada:

The release is available on:

Your semantic-release bot :package::rocket: