`headers` and `status` are not provided when response `body` is undefined

[AdamFoskit]

🐞 Bug Report

If an API call has a response body of undefined, the useFetchye hook's data returned is undefined, and does not provide the status or headers from the response.

To Reproduce

Use the useFetchye hook to query an API that returns an undefined body. (Possible for status 201 and 204.)

Expected behavior

The data returned from the useFetchye hook should always contain the status and headers when there is a response from the API call.

Screenshots

Console log of output response from useFetchye hook for a response with an undefined body.

Console log of output for the fetch for the same API call (before .json() was called on the response)

System information

• OS: Windows
• Browser (if applies) Chrome
• Version of fetchye: 1.0.1
• Node version: 12.18.1

Additional context

[ghost]

Looks like the issue may be here.

try {
    res = await fetchClient(key, options);
    const body = await res.json();
    payload = {
      body,
      ok: res.ok,
      headers: headersToObject(res.headers),
      status: res.status,
    };
  } catch (requestError) {
    // eslint-disable-next-line no-console
    console.error(requestError);
    error = requestError;
  }

We're expecting the response to have a body retrievable by .json()

We should probably check if the response is ok, if not, get the error from res.text() and return the rest of the payload.

[AdamFoskit]

@jgolden17 Yeah, that looks like the problem.

[oneamexbot]

This issue is stale because it has been open 30 days with no activity.

[oneamexbot]

This issue is stale because it has been open 30 days with no activity.

[JAdshead]

this should be resolved by https://github.com/americanexpress/fetchye/pull/38