fix to handle the json parsing error that occurs when an api response is empty (no content)

sowmyab9 commented 3 years ago

Description

This PR fixes an error that is thrown when api responds with a 204 or empty response.

Motivation and Context

When an API returns 204 or a response that is empty, currently an error is thrown as "Unexpected end of JSON input". Resulting in the data object being returned as undefined and triggering the ERROR action. This PR catches this error and returns a .text() version. So that the result is consistent with Fetchye response. The response will have a data object with a status, ok, headers and an empty body. Error object will remain undefined.

How Has This Been Tested?

i have added unit tests to test this scenario and also updated existing tests. simulated the scenario with fetch and real apis returning 204 and 201(with empty response)

Types of Changes

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation (adding or updating documentation)
[ ] Dependency update

Checklist:

[ ] My change requires a change to the documentation and I have updated the documentation accordingly.
[X] My changes are in sync with the code style of this project.
[X] There aren't any other open Pull Requests for the same issue/update.
[ ] These changes should be applied to a maintenance branch.
[ ] I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using Fetchye?

Developers can continue using Fetchye even when their APIs return no data :)

CLAassistant commented 3 years ago

All committers have signed the CLA.

codesandbox-ci[bot] commented 3 years ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit db0aee1445cea2bab00374b6f4345875c074195e:

Sandbox	Source
quick-install	Configuration
fetchye-provider-install	Configuration
fetchye-redux-provider-install	Configuration
nextjs-fetchye-ssr	Configuration

americanexpress / fetchye