docs(readme): add error handling to examples - Githubissues

americanexpress / fetchye

✨ If you know how to use Fetch, you know how to use Fetchye [fetch-yae]. Simple React Hooks, Centralized Cache, Infinitely Extensible.

Apache License 2.0

43 stars 22 forks source link

docs(readme): add error handling to examples #80

Closed smackfu closed 1 year ago

smackfu commented 1 year ago

Description

Fixes #77

Motivation and Context

The examples do not handle the case where fetch throws, which might lead to unexpected bugs in these edge cases.

How Has This Been Tested?

Documentation update. Similar code is used in our project.

Types of Changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Documentation (adding or updating documentation)
[ ] Dependency update

Checklist:

[x] My change requires a change to the documentation and I have updated the documentation accordingly.
[x] My changes are in sync with the code style of this project.
[x] There aren't any other open Pull Requests for the same issue/update.
[ ] These changes should be applied to a maintenance branch.
[ ] I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using Fetchye?

Better examples that handle all cases.

codesandbox-ci[bot] commented 1 year ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 830cf236385b79c6e576b33c93e048809592cde7:

Sandbox	Source
americanexpress/fetchye	Configuration
americanexpress/fetchye	Configuration
americanexpress/fetchye	Configuration