search

americanexpress / jest-image-snapshot

✨ Jest matcher for image comparisons. Most commonly used for visual regression testing.
Apache License 2.0
3.83k stars 198 forks source link

Jest 28 support #296

Closed bendehghan closed 2 years ago

bendehghan commented 2 years ago

Hi guys, When do you think you'll add support for the new jest version? Thanks, Ben

afc163 commented 2 years ago

+1

图片
ba32107 commented 2 years ago

+1 please

Rendez commented 2 years ago

+1

bendehghan commented 2 years ago

Guys, any update on this would help. Thanks :) Is the PR blocked for a reason other than not having been reviewed?

AnderssonPeter commented 2 years ago

It would be great if this would be resolved!

bendehghan commented 2 years ago

are we any closer to this?

Thanks

JAdshead commented 2 years ago

Closing as this was resolved in the 5.0.0 release. Thank you @aarongoldenthal for the contribution

ba32107 commented 2 years ago

Would it be possible to update the corresponding type definition too? https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/jest-image-snapshot

10xLaCroixDrinker commented 2 years ago

@ba32107 feel free to open the PR