americanexpress / jest-image-snapshot

✨ Jest matcher for image comparisons. Most commonly used for visual regression testing.
Apache License 2.0
3.81k stars 197 forks source link

feat: remove snap suffix if use custom identifier #305

Closed kibala145 closed 1 year ago

kibala145 commented 1 year ago

Description

When using customSnapshotIdentifier do not add -snap suffix

Motivation and Context

It would be great not to force '-snap' suffix so users are able to customize file name providing customSnapshotIdentifier There are some discussion about this https://github.com/americanexpress/jest-image-snapshot/issues/107

How Has This Been Tested?

Current test cases passed. Some of them corrected.

Types of Changes

Checklist:

What is the Impact to Developers Using Jest-Image-Snapshot?

Better screenshots naming

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

kibala145 commented 1 year ago

Resolved conflicts locally and pushed with force so licence/cla check passed. There are no new changes.

oneamexbot commented 1 year ago

:tada: This PR is included in version 5.2.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: