chore(jest)!: add support for jest v29

aloisklink commented 2 years ago

Description

Add support for Jest v29.

Jest v29 drops support for Node v12/v17, so I've updated the package.json to contain the same Node support as Jest.

The only other major breaking change in Jest v29 is that the default snapshot format has changed slightly, but that only changes the stored jest snapshots slighty (see https://jestjs.io/blog/2022/08/25/jest-29).

BREAKING CHANGE: Drop support for Node v12 and Node v17, as Jest v29 does not support these versions.

Motivation and Context

Resolves #308

How Has This Been Tested?

I've tried testing this branch on my own project (remark-mermaid-dataurl) using the following, and it seems to work fine.

    "jest": "^29.0.0",
    "jest-image-snapshot": "git+https://github.com/aloisklink/jest-image-snapshot.git#chore/update-jest-to-v29",

Types of Changes

[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Dependency update

Checklist:

[x] My change requires a change to the documentation and I have updated the documentation accordingly.
- README.md modified.
[x] My changes are in sync with the code style of this project.
[x] There aren't any other open Pull Requests for the same issue/update.
[ ] These changes should be applied to a maintenance branch.
- I'm not 100% sure what this means (I'm guessing this means backporting to older MAJOR versions?), but I don't think this applies in my case.
[x] I have added the Apache 2.0 license header to any new files created.
- No files added.

What is the Impact to Developers Using Jest-Image-Snapshot?

Adds support for Jest 29.

BREAKING CHANGE: Drops support for Node v12 and Node v17.

CLAassistant commented 2 years ago

All committers have signed the CLA.

Remi-p commented 2 years ago

Hey, I don't have the skills to validate the "code" part of your PR, but using your branch & jest 29

    "jest": "^29.0.0",
    "jest-image-snapshot": "git+https://github.com/aloisklink/jest-image-snapshot.git#chore/update-jest-to-v29",

works in one of our project too. Thanks for the MR!

nbeloglazov commented 2 years ago

Hi folks! Any update on this PR? Would be nice to get rid of warnings when running npm install about jest-image-snapshot not being compatable with jest 29.

nbeloglazov commented 2 years ago

@anescobar1991 could you review this PR? Or someone from one-amex-admins :)

Corrob commented 2 years ago

Is there a reason this isn't being approved? Are there any risks involved?

This is blocking all projects that use this jest-image-snapshot from upgrading to jest 29 so it would be nice to sort this out sooner than later.

oneamexbot commented 2 years ago

:tada: This PR is included in version 6.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

Corrob commented 2 years ago

Thanks for getting this one out the door!

americanexpress / jest-image-snapshot