fix: Changes to consider only updatePassedSnapshot if updateSnapshot is also true

goverdhan07 commented 1 year ago

Description

updatePassedSnapshot to only update "passed" snapshots when jest --updatesnapshot flag is present.

fixes: #325

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation (adding or updating documentation)
[ ] Dependency update

[x] My change requires a change to the documentation and I have updated the documentation accordingly.
[x] My changes are in sync with the code style of this project.
[x] There aren't any other open Pull Requests for the same issue/update.
[x] These changes should be applied to a maintenance branch.
[x] I have added the Apache 2.0 license header to any new files created.

CLAassistant commented 1 year ago

All committers have signed the CLA.

chetan1507 commented 1 year ago

can we please merge this? This is a very useful fix for CI detection in case of missing snapshots.

10xLaCroixDrinker commented 1 year ago

Please sign the CLA

goverdhan07 commented 1 year ago

Please sign the CLA

hi @10xLaCroixDrinker I have signed the cla but it still says - not signed. Maybe the Github action is broken? please check and let me know.

10xLaCroixDrinker commented 1 year ago

For the CLA to work, you need to amend your commits to use the email associated with your GitHub account

goverdhan07 commented 1 year ago

@code-forger / @10xLaCroixDrinker Please re-review this PR. I have fixed CLA issue now.

oneamexbot commented 1 year ago

:tada: This PR is included in version 6.1.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: