chore: remove mkdirp in favor of recursive fs.mkdir - Githubissues

americanexpress / jest-image-snapshot

✨ Jest matcher for image comparisons. Most commonly used for visual regression testing.

Apache License 2.0

3.84k stars 200 forks source link

chore: remove mkdirp in favor of recursive fs.mkdir #329

Closed guilhermehn closed 1 year ago

guilhermehn commented 1 year ago

Description

Removes mkdirp from the project and replace it with Node's native recursive directory creation.

The recursive: true option is supported since Node v10.12.0 and is recommended by mkdirp since version 1.0:

Use native fs.mkdir(path, { recursive: true }) when available.

Motivation and Context

One less dependency to be managed by jest-image-snapshot
This version of mkdirp is very outdated

How Has This Been Tested?

  System:
    OS: Linux 5.19 Ubuntu 22.04.2 LTS 22.04.2 LTS (Jammy Jellyfish)
    CPU: (8) x64 Intel(R) Core(TM) i7-8650U CPU @ 1.90GHz
    Memory: 7.29 GB / 31.23 GB
    Container: Yes
    Shell: 5.1.16 - /bin/bash

All unit tests are passing with Node 14.15.0 (least supported version), 16.20.0 (latest v16) and 18.15.0 (latest v18).

Types of Changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation (adding or updating documentation)
[x] Dependency update

Checklist:

[ ] My change requires a change to the documentation and I have updated the documentation accordingly.
[x] My changes are in sync with the code style of this project.
[x] There aren't any other open Pull Requests for the same issue/update.
[ ] These changes should be applied to a maintenance branch.
[ ] I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using Jest-Image-Snapshot?

None.

CLAassistant commented 1 year ago

All committers have signed the CLA.

10xLaCroixDrinker commented 1 year ago

Thank you for the contribution!

oneamexbot commented 1 year ago

:tada: This PR is included in version 6.1.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: