ci: windows & mac - Githubissues

americanexpress / jest-image-snapshot

✨ Jest matcher for image comparisons. Most commonly used for visual regression testing.

Apache License 2.0

3.84k stars 200 forks source link

ci: windows & mac #342

Closed LeoDog896 closed 1 year ago

LeoDog896 commented 1 year ago

Description

This PR adds a matrix to run the CI on Windows, Mac, and Linux, and fixes a broken test on windows because of a different path name

Motivation and Context

To stop operating system regressions and allow for testing the repository in a Windows development environment.

Types of Change

[x] Testing change

Checklist:

[x] My change requires a change to the documentation and I have updated the documentation accordingly.
[x] My changes are in sync with the code style of this project.
[x] There aren't any other open Pull Requests for the same issue/update.
[x] These changes should be applied to a maintenance branch.
[x] I added the Apache 2.0 license header to any new files.

What is the Impact on Developers Using Jest-Image-Snapshot?

Very little - this stops possible regressions in path systems, as what happened with https://github.com/privatenumber/pkgroll/issues/10

Matthew-Mallimo commented 1 year ago

Thank you!

oneamexbot commented 12 months ago

:tada: This PR is included in version 6.3.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: