Closed cameronhunter closed 5 months ago
Thanks for the contribution @cameronhunter!
It looks like you've accidentally created a release in your branch? (version bump and changelog update)
I'd rather get the repo updated to be running on Node.js 18 & 20 than put more into Node.js 14.
@10xLaCroixDrinker I've rebased my changes which removed the version bump and changelog updates. It's been a while since I created this pull request so I can't remember if I made those changes or if they were automatic.
w.r.t. updating to node 18 and 20 – I completely agree. I wanted to make minimal changes to the repo to unblock some feature development. The repo is highly opinionated and I didn't want to make decisions about removing lockfile-lint
.
Description
npm install
made changes topackage-lock.json
.Motivation and Context
When following the CONTRIBUTING guide, I ran
npm install
using the latest LTS version of node (v20).npm
warned me about an old lockfile version and that it would rewrite it.However, the
lockfile-lint
dependency is not compatible with the latest lockfile version. I tried again with node v18 and v16 but it had the same issue. Finally, node v14 does not attempt to rewrite thepackage-lock.json
file and works withlockfile-lint
, however, it does still make a small change to the file.I don't see any documentation on what version of node should be used with the repository – is there a recommendation?
How Has This Been Tested?
npm run test
Types of Changes
Checklist:
What is the Impact to Developers Using Jest-Image-Snapshot?
Ensure to use the version of node specified in the documentation and
.nvmrc
file.