americanexpress / nodes

A GraphQL JVM Client - Java, Kotlin, Scala, etc.
Apache License 2.0
307 stars 70 forks source link

Fetch uses serializeMapper from ObjectMapperFactory to deserialize #118

Open jpasquers opened 3 years ago

jpasquers commented 3 years ago

https://github.com/americanexpress/nodes/blob/9bc0d442e67248d0899429ae8548340c055ee50f/nodes/src/main/java/io/aexp/nodes/graphql/Fetch.java#L141

^The mapper referenced here is the serializeMapper, not a mapperFactory.newDeserializeMapper(). When we had to override the ObjectMapperFactory to do custom deserialization, we ended up having to add the custom logic to the newSerializeMapper()