Support JSR-310 classes, pluggable ObjectMapper

americanexpress / nodes

A GraphQL JVM Client - Java, Kotlin, Scala, etc.

Apache License 2.0

307 stars 70 forks source link

Support JSR-310 classes, pluggable ObjectMapper #54

Closed mkalen closed 5 years ago

mkalen commented 5 years ago

Default support for serdes of Java 8+ date/time classes (JSR-310) Pluggable ObjectMapper factory for eg wiring Spring mapper through custom implementation

NB - breaking change in public API.

Potential close for #25 (if a custom ObjectMapperFactory implementation is used that wires Nodes with a Spring-supplied ObjectMapper instance)

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 80

26 of 26 (100.0%) changed or added relevant lines in 5 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.06%) to 98.611%

Totals
Change from base Build 78:	0.06%
Covered Lines:	497
Relevant Lines:	504

💛 - Coveralls

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 80

26 of 26 (100.0%) changed or added relevant lines in 5 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.06%) to 98.611%

Totals
Change from base Build 78:	0.06%
Covered Lines:	497
Relevant Lines:	504

💛 - Coveralls

chemdrew commented 5 years ago

awesome, thanks a bunch for this contribution