americanexpress / nodes

A GraphQL JVM Client - Java, Kotlin, Scala, etc.
Apache License 2.0
307 stars 70 forks source link

feat(GraphQLArgument): introduce optional arguments #57

Closed mkalen closed 5 years ago

mkalen commented 5 years ago

Extend GraphQLArgument annotation class with field "optional" (default to false for backward compatibility)

Proposal for handling of API with mutually exclusive arguments using annotations. See test cases in GraphQLRequestEntityTest.

Closes #56

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 81


Changes Missing Coverage Covered Lines Changed/Added Lines %
nodes/src/main/java/io/aexp/nodes/graphql/Parameter.java 8 9 88.89%
<!-- Total: 37 38 97.37% -->
Totals Coverage Status
Change from base Build 78: 0.3%
Covered Lines: 499
Relevant Lines: 505

💛 - Coveralls
coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 82


Totals Coverage Status
Change from base Build 78: 0.5%
Covered Lines: 500
Relevant Lines: 505

💛 - Coveralls