search

americanexpress / react-albus

✨ React component library for building declarative multi-step flows.
Apache License 2.0
1.1k stars 89 forks source link

React 18 support? (Update package.json?) #116

Open qathom opened 2 years ago

qathom commented 2 years ago

Hello! Thanks for making react-albus. I'm using react-albus with react 18. It's working as expected but we need to force the install (npm i --legacy-peer-deps). Indeed, peer dependencies allow react v15 or v16. https://github.com/americanexpress/react-albus/blob/main/package.json#L79

I really like this project, but I have the impression that it is less and less active sadly.

kylemcd commented 1 year ago

This PR addresses React 18 support: https://github.com/americanexpress/react-albus/pull/123

zedosan921 commented 1 year ago

Any updates on this? @10xLaCroixDrinker @kylemcd

kylemcd commented 1 year ago

@zedosan921 The PR is opened, just waiting on a yes / no from the maintainers. In the meantime you could install the React 18 version of the package to your project by adding this to your package.json

"react-albus": "github:kylemcd/react-albus#build",

Safer option would definitely be to fork my repo and update the package to pull from there: https://github.com/kylemcd/react-albus

Let me know if you have any question, at this point it seems highly unlikely that my PR gets merged in or the maintainers will update to support React 18 themselves.

smackfu commented 1 year ago

How much of that PR was to actively support React 18? My quick review didn't really show any code changes besides formatting updates, just the package.json updates.

kylemcd commented 1 year ago

@smackfu As stated in the PR title, the intention was to make the package compatible with React 18. Additionally, compatibility with React 17 was also addressed, as it had been neglected.

I have no intention of investing the time to fully integrate an abandoned repository to support the latest React technology. However, I would like to assist users like myself who are utilizing it in legacy projects and wish to upgrade their dependencies. Due to the warnings encountered during npm install, we are forced to proceed with a forced installation using npm install --force or npm install --legacy-peer-deps. Obviously, this is not an ideal solution.

We have been successfully running my fork of react-albus in a production environment for almost two months now, with React 18 and Next 13, without encountering any issues. I completely understand if you choose not to accept my PR, but I would appreciate it if this repository could either be properly maintained or archived, allowing others to make an informed decision on how to address the problem that react-albus aims to solve.

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 30 days with no activity.

anonmily commented 10 months ago

Is there any update on this?

github-actions[bot] commented 9 months ago

This issue is stale because it has been open 30 days with no activity.