search

americanexpress / react-albus

✨ React component library for building declarative multi-step flows.
Apache License 2.0
1.1k stars 89 forks source link

Jest testing componentWillMount renaming warning #68

Closed Lukortech closed 3 years ago

Lukortech commented 4 years ago

Hi! Sorry to bother but is there a chance for update for Steps and Wizard so that those components will use UNSAFE_?

While testing I am getting this warning which is just a small reminder of how newer version of react handles lifecycles if I am correct.


      Warning: componentWillMount has been renamed, and is not recommended for use. See https://fb.me/react-unsafe-component-lifecycles for details.

      * Move code with side effects to componentDidMount, and set initial state in the constructor.
      * Rename componentWillMount to UNSAFE_componentWillMount to suppress this warning in non-strict mode. In React 17.x, only the UNSAFE_ name will work. To rename all deprecated lifecycles to their new names, you can run `npx react-codemod rename-unsafe-lifecycles` in your project source folder.

      Please update the following components: Steps, Wizard```
github-actions[bot] commented 4 years ago

This issue is stale because it has been open 30 days with no activity.

ryhinchey commented 3 years ago

This issue can be closed. componentWillMount isn't being used in the library any more

Lukortech commented 3 years ago

Thank you for update! :)

aminace-qh commented 1 year ago

@ryhinchey

This issue can be closed. componentWillMount isn't being used in the library any more

Was this change released with the latest version of the lib (v2.0.0)?