search

americanexpress / react-albus

✨ React component library for building declarative multi-step flows.
Apache License 2.0
1.1k stars 89 forks source link

Update README.md #9

Closed prmichaelsen closed 7 years ago

prmichaelsen commented 7 years ago

small semantics change; objects do not have signatures, rather they have structures

CLAassistant commented 7 years ago

CLA assistant check
All committers have signed the CLA.

jackjocross commented 7 years ago

Good catch! Thank you for fixing this.

The failing build is being caused by updates to prettier's formatting that are resulting in linting errors. I'll have to fix that in a later PR so I'm fine accepting this.

prmichaelsen commented 7 years ago

No worries! It's a small thing but I'm glad to hear you care about the small stuff

On Tue, Sep 5, 2017 at 12:05 PM Jack Cross notifications@github.com wrote:

Good catch! Thank you for fixing this.

The failing build is being caused by updates to prettier's formatting https://github.com/prettier/prettier/releases/tag/1.6.0 that are resulting in linting errors. I'll have to fix that in a later PR so I'm fine accepting this.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/americanexpress/react-albus/pull/9#issuecomment-327272679, or mute the thread https://github.com/notifications/unsubscribe-auth/AICabL6gvQ2uKBECwwtQKrZ8sB_tousBks5sfZuFgaJpZM4PMTOc .