search

americanhandelsociety / americanhandelsociety-members

0 stars 0 forks source link

Appease django warning #124

Closed reginafcompton closed 2 years ago

reginafcompton commented 2 years ago

I noticed two warnings when deploying a static change to staging today:

I am not entirely sure I understand why this field is being updated, but it seems safe.

Your models in app(s): 'americanhandelsociety_app' have changes that are not yet reflected in a migration, and so won't be applied.

This was leftover from the Django 3.2 upgrade. Here a nice article explaining: https://dev.to/weplayinternet/upgrading-to-django-3-2-and-fixing-defaultautofield-warnings-518n

americanhandelsociety_app.Address: (models.W042) Auto-created primary key used when not defining a primary key type, by default 'django.db.models.AutoField'.
    HINT: Configure the DEFAULT_AUTO_FIELD setting or the AmericanHandelSocietyAppConfig.default_auto_field attribute to point to a subclass of AutoField, e.g. 'django.db.models.BigAutoField'.
ipn.PayPalIPN: (models.W042) Auto-created primary key used when not defining a primary key type, by default 'django.db.models.AutoField'
reginafcompton commented 2 years ago

@ecedmondson - THIS IS NOT URGENT. Please review after your trip (unless the bears or mushrooms get you first).

ecedmondson commented 2 years ago

This seems familiar somehow, as in I remember reading something like this, or maybe this, but I'm really struggling to remember.

ecedmondson commented 2 years ago

Please review after your trip (unless the bears or mushrooms get you first).

Enjoy the vague/implied logic here of the word unless, that: if the bears or mushrooms gets me on the trip, then ghost-Emily can review at anytime she pleases. It's like trying to understand the word until In usage to fourth-century greek thinkers.