search

americanhandelsociety / americanhandelsociety-members

0 stars 0 forks source link

As a Member, I can see a "confirmation" message after paying my membership-renewal fees #132

Closed reginafcompton closed 1 year ago

reginafcompton commented 2 years ago

As a Member, I can see a "confirmation" message after paying my membership-renewal fees

Dev notes

This could happen in two places:

  1. add renewal_confirmation html, view, and url
  2. OR redirect to the users Profile page
reginafcompton commented 2 years ago

@ecedmondson re: https://github.com/americanhandelsociety/americanhandelsociety-members/issues/122#issuecomment-1279615843

do you have a preference? Is this something board will decide at the above mentioned meeting?

I do not have a preference.

The separate confirmation page would resemble the flow when a user joins: https://github.com/americanhandelsociety/americanhandelsociety-members/blob/main/americanhandelsociety_app/templates/payment_confirmation.html

I am sort of inclined to do it this ^^^ way, because: (1) it will be easy to build, (2) it follows an existing user flow (so, yay, consistency), and (3) I am not sure how the Profile redirect will look (e.g., would we should an alert somewhere?...design is hard).

Do you have a strong opinion? The board will not care.

ecedmondson commented 2 years ago

My strong opinion is that users should know what to expect for whatever a userflow is, so if the join flow is familiar then we should mimic that. That is to say, my strong opinion is that (2) is pretty important.

Just to overly clear:

reginafcompton commented 2 years ago

Great! Let's go with the standalone confirmation page (rather than redirecting to the Profile page).

renew button url which leads to renewal form/html

The renew link should be on the Profile page and somewhere else (?) . I was thinking the nav menu. In any case, that work is being done here: https://github.com/americanhandelsociety/americanhandelsociety-members/pull/134/files

Yes, the confirmation page should be a protected view, i.e., users should not be logged out after they renew.

So...this ticket will be very, very simple: basically creating the html + view + url that displays the "Thanks for renewing!" page.

ecedmondson commented 2 years ago

Sounds good. I can take this one in the meantime, though I probably won't start tonight.

reginafcompton commented 2 years ago

Nice! Thank you!

ecedmondson commented 2 years ago

I have a PR but I haven't tested and am getting tired so I think I'll need to get back to this tomorrow