search

americanhandelsociety / americanhandelsociety-members

0 stars 0 forks source link

Issue 161 #162

Closed reginafcompton closed 1 year ago

reginafcompton commented 1 year ago

Some members of the AHS pay their dues via other organizations. (E.g., some members of the Handel Gesellschaft pay dues through HG, not AHS Paypal.)

Long term, all AHS members will likely pay via the AHS Paypal, but for now, we need to exclude the members who continue to pay through their "home" institutions.

This PR implements a solution for excluding such members from the reminder emails.

reginafcompton commented 1 year ago

@ecedmondson - let me know if you have questions about any of this!

It comes as a request from our treasurer, who received a complaint/confused email from one of our German members re: the renewal reminders.

ecedmondson commented 1 year ago

Code looks fine...the changes are actually limited. and the bulk of the line changes are due to pipenv. I'm going to pull this, dry run locally, and also do a gentle walkthrough due to the updates.

ecedmondson commented 1 year ago

I have a port already allocated on...some other terminal. So I can't start up the app. And it's late. I have decided to now test tomorrow. Sorry about that.

reginafcompton commented 1 year ago

Thank you for getting to this so quickly @ecedmondson ! Tomorrow, I'll get it merged and do QA on staging.

ecedmondson commented 1 year ago

Let me know if you need any support to test on staging.

On Mar 19, 2023, at 8:14 PM, Regina Compton @.***> wrote:

 Thank you for getting to this so quickly @ecedmondson ! Tomorrow, I'll get it merged and do QA on staging.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.

ecedmondson commented 1 year ago

You've probably already thought of this...but just in case...there needs to be some way to update the state for the user who joined via HG in production. This PR doesn't address it. Perhaps a migration or something in the admin dashboard? What do you think?

reginafcompton commented 1 year ago

@ecedmondson - yep, I pushed this last night: https://github.com/americanhandelsociety/americanhandelsociety-members/pull/163

It's only about ten members, so I am going to manually set is_member_via_other_organization to True for those members.

Everything looks good on staging by the way! I will deploy to production today.

ecedmondson commented 1 year ago

Oh, I see. Okay, sounds good. Thanks

On Tue, Mar 21, 2023 at 10:30 AM Regina Compton @.***> wrote:

@ecedmondson https://github.com/ecedmondson - yep, I pushed this last night: #163 https://github.com/americanhandelsociety/americanhandelsociety-members/pull/163

It's only about ten members, so I am going to manually set is_member_via_other_organization to True for those members.

Everything looks good on staging by the way! I will deploy to production today.

— Reply to this email directly, view it on GitHub https://github.com/americanhandelsociety/americanhandelsociety-members/pull/162#issuecomment-1478047356, or unsubscribe https://github.com/notifications/unsubscribe-auth/AG63OSPIZG6SDNDGC6ETFD3W5HCQ7ANCNFSM6AAAAAAV7Z7QJI . You are receiving this because you were mentioned.Message ID: <americanhandelsociety/americanhandelsociety-members/pull/162/c1478047356@ github.com>

reginafcompton commented 1 year ago

Deployed to production; manual adjustments made; AHS treasurer + president notified.