search

americanhandelsociety / americanhandelsociety-members

0 stars 0 forks source link

Issue 172: December Final Notice #179

Closed ecedmondson closed 9 months ago

ecedmondson commented 9 months ago

December final notice

ecedmondson commented 9 months ago

Bike ride thoughts for self later: can't assume that the December 2023 recipients fit criteria of updated query. That will need to be a post 01/12/2023 change

ecedmondson commented 9 months ago

I did some rebasing to get time machine in here, updated the tests, rebased the most recent commit to switch back to the qs method. I am testing from the shell too, but wouldn't mind other eyes.

ecedmondson commented 9 months ago

This looks great. I did not manually test, however. (...but the changes look straightforward, so I am not worried.)

I think you are more confident than I am. That's fine!

reginafcompton commented 9 months ago

I ran through the critical flows on the staging site, and nothing seems broken (which means the small upgrades did not introduce regressions).

I am going to deploy to production. Thanks again! (And happy thanksgiving.)

ecedmondson commented 9 months ago

I ran through the critical flows on the staging site, and nothing seems broken (which means the small upgrades did not introduce regressions).

I am going to deploy to production. Thanks again! (And happy thanksgiving.)

Thanks for letting me know! I'm so glad it seems to be working.

I was thinking about picking up another issue, if you don't mind.

(And happy thanksgiving to you too!)