search

americanhandelsociety / americanhandelsociety-members

0 stars 0 forks source link

Issue 172 Part B: time machine #180

Closed ecedmondson closed 1 year ago

ecedmondson commented 1 year ago

I don't particularly like putting package changes in feature PRs.

What do you think?

ecedmondson commented 1 year ago

Oh actually...I am still sort of testing this flow locally. I assumed you were not online.

On that note, I forgot to update the paypal flow. My personal computer also auto-auths to Paypal. Anyway, I think I might have accidentally just become a member. Which is fine I guess.

reginafcompton commented 1 year ago

Anyway, I think I might have accidentally just become a member.

I just checked: no Emily in the Handel society. If you are testing locally, it will redirect to a sandbox, which should not take your money.

ecedmondson commented 1 year ago

I just checked: no Emily in the Handel society. If you are testing locally, it will redirect to a sandbox, which should not take your money.

Yeah, I figured that out the second time when I went back. Incidentally, I have lost the login credentials so I can't test that flow, but I did notice that django-paypal didn't upgrade versions.

Are you worried about any of the other package updates in here?

Edit: thank you for having checked. It is good to know, though I wouldn't have minded making a charitable donation at all

reginafcompton commented 1 year ago

Are you worried about any of the other package updates in here?

Nope. I think this seems safe. I also QA staging (typical flows: sign up, login, email reminder) before I do a production deployment. (And yes: I need to look up the Paypal credentials, again.)

ecedmondson commented 1 year ago

Nope. I think this seems safe. I also QA staging (typical flows: sign up, login, email reminder) before I do a production deployment. (And yes: I need to look up the Paypal credentials, again.)

I am going to rebase the other PR with this if you want to wait.