americanhandelsociety / americanhandelsociety-members

0 stars 0 forks source link

[Issue-176] Add UI for publish_member_name_consent #182

Closed reginafcompton closed 10 months ago

reginafcompton commented 11 months ago

Description

This PR adds a UI for the new Member model field: publish_member_name_consent. It implements the following:

  1. exposes the field in the admin dashboard (so the AHS newsletter editor can use it)
  2. adds the field to the member-edit form
  3. exposes the value of publish_member_name_consent (in a nice way) on the profile page

N.b., The commit history for this PR is a little messy, since I had to revise my initial implementation after getting feedback from AHS stakeholders.

Manual testing

pipenv run python manage.py createsuperuser

A non-circle user should NOT see the new field in the update form, nor should she see additional data on her profile page.

ecedmondson commented 10 months ago

Thanks for the UI Screenshots. Going to run locally.

ecedmondson commented 10 months ago

Sorry I didn't assign this back to you until just now, @reginafcompton . I thought I had...but I noticed you merged the other and not this one.

Oh and, surprise, happy new year: merge conflicts.

reginafcompton commented 10 months ago

Closes issue #176