search

americanpanorama / panorama-foreignborn

Foreign-Born Population 1850-2010
8 stars 2 forks source link

"no foreign-born population" message in 1850 and 1860 #5

Open almccon opened 8 years ago

almccon commented 8 years ago

In 1850 and 1860 we don't have county-level data, so we can't change the display of the map when you select a country. However, we should leave the bar chart in place, instead of loading the "This country had no foreign-born population in the selected year" message.

foreignborn_bug

ebrelsford commented 8 years ago

@almccon I'm not sure how you'd like to leave the bar chart in place if there is no data. Would this look like a list of countries with 0s next to them? That feels slightly inconsistent to me with existing behavior since the countries list shrinks as there are fewer to show:

foreignborn-barchart

almccon commented 8 years ago

When a county is selected in 1850 or 1860 there should be no bar chart, so you're seeing the correct behavior. But when a country is selected, the bar chart erroneously disappears.

almccon commented 8 years ago

The similarity between the words county and country has been driving us crazy throughout this project!

ebrelsford commented 8 years ago

Ahhh got it, thanks @almccon!