amerkoleci / Vortice.Windows

.NET bindings for Direct3D12, Direct3D11, WIC, Direct2D1, XInput, XAudio, X3DAudio, DXC, Direct3D9 and DirectInput.
MIT License
1.02k stars 73 forks source link

.NET Standard support #415

Closed YoshiRulz closed 11 months ago

YoshiRulz commented 11 months ago

The netstandard2.0 target was dropped in https://github.com/amerkoleci/Vortice.Windows/commit/0445f50f26b471b9d9147cf98c2da3e99aa23836 but it's not clear why. Is it possible to add it back? If not, could you release a 2.4.3 with updated NuGet dependencies?

amerkoleci commented 11 months ago

Hi, That won't be possible, as I'll need to keep lot of workarounds to support netstandard2.0, if you find clear way feel free to send PR and I can think about it.

Thanks!

YoshiRulz commented 11 months ago

I tried building a few commits but they all failed with something like this:

$> git checkout fd75e80
$> dotnet pack Vortice.Windows.sln --configuration Release -p:Packing=true -p:EnableWindowsTargeting=true
MSBuild version 17.8.0+6cdef4241 for .NET
  Determining projects to restore...
  Restored /home/yoshi/Documents/Vortice.Windows/src/tests/Vortice.Dxc.Test/Vortice.Dxc.Test.csproj (in 461 ms).
  Restored /home/yoshi/Documents/Vortice.Windows/src/tests/Vortice.DXGI.Tests/Vortice.DXGI.Tests.csproj (in 461 ms).
  Restored /home/yoshi/Documents/Vortice.Windows/src/samples/HelloDirectStorage/HelloDirectStorage.csproj (in 464 ms).
  Restored /home/yoshi/Documents/Vortice.Windows/src/Vortice.XAudio2/Vortice.XAudio2.csproj (in 463 ms).
  Restored /home/yoshi/Documents/Vortice.Windows/src/samples/XInput/HelloXInput.csproj (in 6 ms).
  Restored /home/yoshi/Documents/Vortice.Windows/src/samples/MediaFoundation/EnumerateDevices/EnumerateDevices.csproj (in 6 ms).
  Restored /home/yoshi/Documents/Vortice.Windows/src/samples/MediaFoundation/AudioPlay/AudioPlay.csproj (in 9 ms).
  Restored /home/yoshi/Documents/Vortice.Windows/src/samples/HelloXAudio2/HelloXAudio2.csproj (in 8 ms).
  Restored /home/yoshi/Documents/Vortice.Windows/src/tests/Vortice.D3DCompiler.Test/Vortice.D3DCompiler.Test.csproj (in 28 ms).
  Restored /home/yoshi/Documents/Vortice.Windows/src/samples/HelloDirectML/HelloDirectML.csproj (in 25 ms).
  Restored /home/yoshi/Documents/Vortice.Windows/src/samples/HelloDirectInput/HelloDirectInput.csproj (in 22 ms).
  Restored /home/yoshi/Documents/Vortice.Windows/src/samples/Vortice.SampleFramework/Vortice.SampleFramework.csproj (in 64 ms).
  Restored /home/yoshi/Documents/Vortice.Windows/src/samples/HelloDirect3D12Raytracing/HelloDirect3D12Raytracing.csproj (in 13 ms).
  Restored /home/yoshi/Documents/Vortice.Windows/src/samples/HelloDirect3D12/HelloDirect3D12.csproj (in 16 ms).
  Restored /home/yoshi/Documents/Vortice.Windows/src/samples/AdvancedTextRenderingApp/AdvancedTextRenderingApp.csproj (in 13 ms).
  Restored /home/yoshi/Documents/Vortice.Windows/src/Vortice.XInput/Vortice.XInput.csproj (in 5 ms).
  Restored /home/yoshi/Documents/Vortice.Windows/src/samples/HelloDirect3D11/HelloDirect3D11.csproj (in 24 ms).
  Restored /home/yoshi/Documents/Vortice.Windows/src/Vortice.DirectML/Vortice.DirectML.csproj (in 21 ms).
  Restored /home/yoshi/Documents/Vortice.Windows/src/Vortice.UIAnimation/Vortice.UIAnimation.csproj (in 14 ms).
  Restored /home/yoshi/Documents/Vortice.Windows/src/Vortice.Dxc/Vortice.Dxc.csproj (in 5 ms).
  Restored /home/yoshi/Documents/Vortice.Windows/src/Vortice.MediaFoundation/Vortice.MediaFoundation.csproj (in 8 ms).
  Restored /home/yoshi/Documents/Vortice.Windows/src/Vortice.DirectX/Vortice.DirectX.csproj (in 20 ms).
  Restored /home/yoshi/Documents/Vortice.Windows/src/Vortice.DirectStorage/Vortice.DirectStorage.csproj (in 9 ms).
  Restored /home/yoshi/Documents/Vortice.Windows/src/Vortice.DirectSound/Vortice.DirectSound.csproj (in 7 ms).
  Restored /home/yoshi/Documents/Vortice.Windows/src/Vortice.DirectInput/Vortice.DirectInput.csproj (in 21 ms).
  Restored /home/yoshi/Documents/Vortice.Windows/src/Vortice.Direct3D9/Vortice.Direct3D9.csproj (in 7 ms).
  Restored /home/yoshi/Documents/Vortice.Windows/src/Vortice.DirectComposition/Vortice.DirectComposition.csproj (in 9 ms).
  Restored /home/yoshi/Documents/Vortice.Windows/src/Vortice.Direct3D12/Vortice.Direct3D12.csproj (in 11 ms).
  Restored /home/yoshi/Documents/Vortice.Windows/src/Vortice.Direct2D1/Vortice.Direct2D1.csproj (in 13 ms).
  Restored /home/yoshi/Documents/Vortice.Windows/src/Vortice.Direct3D11/Vortice.Direct3D11.csproj (in 21 ms).
  Restored /home/yoshi/Documents/Vortice.Windows/src/Vortice.DXGI/Vortice.DXGI.csproj (in 11 ms).
  Restored /home/yoshi/Documents/Vortice.Windows/src/Vortice.D3DCompiler/Vortice.D3DCompiler.csproj (in 12 ms).
  Restored /home/yoshi/Documents/Vortice.Windows/src/Vortice.WinUI/Vortice.WinUI.csproj (in 153 ms).
/home/yoshi/.nuget/packages/sharpgentools.sdk/2.1.2-beta/Sdk/Sdk.targets(191,5): error MSB4044: The "SharpGenTask" task was not given a value for the required parameter "CastXmlExecutable". [/home/yoshi/Documents/Vortice.Windows/src/Vortice.Dxc/Vortice.Dxc.csproj]
/home/yoshi/.nuget/packages/sharpgentools.sdk/2.1.2-beta/Sdk/Sdk.targets(191,5): error MSB4044: The "SharpGenTask" task was not given a value for the required parameter "CastXmlExecutable". [/home/yoshi/Documents/Vortice.Windows/src/Vortice.DirectX/Vortice.DirectX.csproj]
  Vortice.XInput -> /home/yoshi/Documents/Vortice.Windows/bin/Vortice.XInput/Release/net7.0/Vortice.XInput.dll
  Vortice.XInput -> /home/yoshi/Documents/Vortice.Windows/bin/Vortice.XInput/Release/net8.0/Vortice.XInput.dll
/home/yoshi/.nuget/packages/sharpgentools.sdk/2.1.2-beta/Sdk/Sdk.targets(191,5): error MSB4044: The "SharpGenTask" task was not given a value for the required parameter "CastXmlExecutable". [/home/yoshi/Documents/Vortice.Windows/src/Vortice.Direct3D9/Vortice.Direct3D9.csproj]
/home/yoshi/.nuget/packages/sharpgentools.sdk/2.1.2-beta/Sdk/Sdk.targets(191,5): error MSB4044: The "SharpGenTask" task was not given a value for the required parameter "CastXmlExecutable". [/home/yoshi/Documents/Vortice.Windows/src/Vortice.DirectX/Vortice.DirectX.csproj::TargetFramework=net7.0]
/home/yoshi/.nuget/packages/sharpgentools.sdk/2.1.2-beta/Sdk/Sdk.targets(191,5): error MSB4044: The "SharpGenTask" task was not given a value for the required parameter "CastXmlExecutable". [/home/yoshi/Documents/Vortice.Windows/src/Vortice.UIAnimation/Vortice.UIAnimation.csproj]
  The package Vortice.XInput.3.4.1-beta is missing a readme. Go to https://aka.ms/nuget/authoring-best-practices/readme to learn why package readmes are important.
  Successfully created package '/home/yoshi/Documents/Vortice.Windows/artifacts/Vortice.XInput.3.4.1-beta.nupkg'.

I'm guessing it relates to SharpGenTools/SharpGenTools#111.

My other suggestion remains.