amethyst / amethyst

Data-oriented and data-driven game engine written in Rust
https://amethyst.rs/
Other
7.99k stars 743 forks source link

Unsupported png format #938

Closed AnneKitsune closed 6 years ago

AnneKitsune commented 6 years ago

The png images found here https://github.com/KhronosGroup/glTF-Sample-Models/tree/master/2.0/Cube/glTF cannot be loaded by the engine currently.

Stacktrace here https://gist.github.com/jojolepro/7444496769d19b752fb9333e29cc2eaf

Valinora commented 6 years ago

I'd like to take a look at this.

Do you have a gist with how you were loading the scene?

AnneKitsune commented 6 years ago

https://github.com/jojolepro/hoppinworldv2

AnneKitsune commented 6 years ago

There is a lot of unrelated things in there. I suggest modifying the gltf example of amethyst.

marciusvinicius commented 6 years ago

@Valinora Are you current look this?

Valinora commented 6 years ago

@marciusvinicius I've been too busy, sorry

marciusvinicius commented 6 years ago

@Valinora I will try take a look, I'm a newbie here and I want something simple to start. thanks

LucioFranco commented 6 years ago

@marciusvinicius great, feel free to pop on discord if you need some help.

AnneKitsune commented 6 years ago

So an easy way to start would be to

marciusvinicius commented 6 years ago

Thanks @jojolepro I'm starting this today. hope I can fix it :D thanks for all supported

marciusvinicius commented 6 years ago

Hey @jojolepro, Following your tips and using the 'gltf cube' I get the right result. How you can see above

Image

Maybe I'm using something different from you, I'm on master and using the GLTF example to run this.

The only thing I note, is the texture don't look right, how you can see on this exemple redering on three.js They have some "stone" texture

Image with right texture

But This can be something with light, I can't say.

AnneKitsune commented 6 years ago

image

AnneKitsune commented 6 years ago

Not sure why, but the issue fixed itself. Thanks for checking it out :)

marciusvinicius commented 6 years ago

@jojolepro nice, Was nice, look the code, I'm understand better the amethyst now.

Rhuagh commented 6 years ago

My guess is that those pngs are progressive, which we didnt support before, but someone made a PR not that long ago for that.